benchmark cpu: drop KDF section#9665
Merged
ThomasWaldmann merged 2 commits intoMay 24, 2026
Merged
Conversation
…worth benchmarking
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
+ Coverage 83.00% 83.62% +0.61%
==========================================
Files 90 90
Lines 15549 15539 -10
Branches 2340 2337 -3
==========================================
+ Hits 12907 12995 +88
+ Misses 1887 1806 -81
+ Partials 755 738 -17 ☔ View full report in Codecov by Sentry. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
Thanks! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the KDF section from
do_benchmark_cpu.KDFs are supposed to be slow, that's the whole point. Timing them gives no useful signal, and the benchmark output already said so:
"KDFs (slow is GOOD, use argon2!)".Suggested in #9664 (review).
number_kdfand theFlexiKeyimport, both only used by that blockNo logic changes.
Checklist