perf: hoist loop-invariant division out of reduce's cell loop#439
Open
henryiii wants to merge 1 commit into
Open
perf: hoist loop-invariant division out of reduce's cell loop#439henryiii wants to merge 1 commit into
henryiii wants to merge 1 commit into
Conversation
Precompute the reduced axis extent once per axis instead of dividing per cell per axis, and skip the merge division when merge == 1. About 5-10% faster on large histograms (Apple clang -O3, M-series). Assisted-by: ClaudeCode:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fairly small change for a nice small speedup in reduction. From #437.
🤖 AI text below 🤖
reducerecomputed(end - begin) / mergefor every axis of every cell and divided bymergeeven when it is 1 (every axis without a rebin command). This precomputes the reduced extent once per axis in the command buffer and skips the no-op division.Benchmarked on 1M-cell histograms (Apple clang -O3): ~6-13% faster for 3d rebin/shrink, ~4% for 2d rebin, no change for 2d shrink.