Conversation
| # Minimum standby delay between conversions in continuous-conversion mode | ||
| # (CONV[2:0], config register bits 9:7). The total cycle time also depends on | ||
| # the averaging setting (see datasheet Table 8-6). | ||
| TMP119_DELAY_0_MS = 0 |
Member
There was a problem hiding this comment.
This is different from the Arduino library: https://github.com/bluerobotics/BlueRobotics_TMP119_Library/blob/master/TMP119.h#L44
| exit(1) | ||
|
|
||
| # init() configures the fastest update rate. Override it here with low-noise | ||
| # settings: average 64 conversions and update roughly once per second. |
Member
There was a problem hiding this comment.
It would be nice to have a detailed comment explaining how the delays are related to sample time, like in:
Collaborator
Author
There was a problem hiding this comment.
I think both of these were already resolved in latter commits, IDK what happened, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.