Fix: handle exceptions in futures#88
Open
678098 wants to merge 1 commit into
Open
Conversation
678098
force-pushed
the
260724_future_exceptions
branch
2 times, most recently
from
July 24, 2026 18:02
83c8e61 to
c0647dc
Compare
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
force-pushed
the
260724_future_exceptions
branch
from
July 24, 2026 18:02
c0647dc to
2dc8c2f
Compare
678098
commented
Jul 24, 2026
| obj.sendConfigureStreamResponse(request); | ||
|
|
||
| // The future must complete with a failure result rather than hang. | ||
| assertEquals(ConfigureQueueResult.UNKNOWN, configFuture.get(FUTURE_TIMEOUT)); |
Collaborator
Author
There was a problem hiding this comment.
The future times out in main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When a control response arrives while a queue is in an unexpected state, the strategy's response handler throws
IllegalArgumentException(aQueueStateManagerprecondition guard) before reachingresultHook().RequestManager's dispatch only logs the exception, so the strategy is never reset (later ops fail withALREADY_IN_PROGRESS) and the caller's future never completes.Fix: Added
QueueControlStrategy.setResponseHandler(), which wraps response handlers so that if one throws, the strategy still completes with a failure (UNKNOWN) and resets. Routed all five response registrations (Open/Configure/Close strategies) through it.