Fix: CloseQueueStrategy leaks queue on failed close-request write - #87
Draft
678098 wants to merge 1 commit into
Draft
Fix: CloseQueueStrategy leaks queue on failed close-request write#87678098 wants to merge 1 commit into
678098 wants to merge 1 commit into
Conversation
678098
force-pushed
the
260724_free_resources_on_failed_close
branch
from
July 24, 2026 17:24
cfda449 to
c737a69
Compare
678098
changed the title
…fails Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
force-pushed
the
260724_free_resources_on_failed_close
branch
from
July 24, 2026 17:32
c737a69 to
0c62a61
Compare
678098
commented
Jul 24, 2026
| onFullyClosed(); | ||
| if (genericResult.isNotConnected()) { | ||
| genericResult = GenericResult.SUCCESS; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
handleConfigureStatus, after a successful configure response, the strategy sends the close-queue request. If that write fails, the queue was markede_CLOSEDbut never removed from the active queue map (keyQueueIdMap), leaving a stuck entry. The URI could not be reopened afterwards.Fix
On close-request write failure in the default scenario, call
onFullyClosed()to remove the queue from the active maps (mirroring the success path inonCloseResponse). Late scenarios, where the queue is already removed, just mark ite_CLOSED.