chore(deps): upgrade @pkcprotocol/pkc-js to 0.0.45#86
Conversation
0.0.45 changes publishChallengeAnswers to take { challengeAnswers: string[] }
instead of a bare string[]; adapt the challenge/mintpass integration tests
to the new signature.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR upgrades the ChangesPKC-JS Dependency Upgrade
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
test/cli/challenge-integration.test.tsOops! Something went wrong! :( ESLint: 8.27.0 Error: ESLint configuration in --config » eslint-config-oclif is invalid:
Referenced from: /.eslintrc test/cli/mintpass-integration.test.tsOops! Something went wrong! :( ESLint: 8.27.0 Error: ESLint configuration in --config » eslint-config-oclif is invalid:
Referenced from: /.eslintrc Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Upgrades
@pkcprotocol/pkc-jsfrom 0.0.41 → 0.0.45 (exact pin).Breaking change handled
0.0.45 changes
Publication.publishChallengeAnswersto take{ challengeAnswers: string[] }instead of a barestring[]. Thesrc/code does not call this API, but two integration tests did — both updated to the new signature.Verification
npm run build && npm run build:test— passnpm run test:cli— 261 passed, 1 skipped (33 files)Summary by CodeRabbit
Chores
@pkcprotocol/pkc-jsdependency to version 0.0.45.Tests