chore(sync): no-op upstream @nuxt/icon client-bundle pre-bundling (8d46034)#235
Merged
Conversation
…46034) Upstream 8d46034 teaches the module to embed the iconify icons it uses into @nuxt/icon's client bundle. b24ui has no @nuxt/icon dependency and renders icons via @bitrix24/b24icons-vue components (no iconify strings, no theme/icons.ts), so there is nothing to port — bookkeeping only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JS8ypVfQSFzYVZzkTHhURb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
8d46034—feat(module): pre-bundle used icons into @nuxt/icon client bundleTeaches the module to embed the iconify icons it uses into
@nuxt/icon's client bundle at build time — newsrc/utils/icons.ts(getClientBundleIcons, parsingi-{collection}-{name}→{collection}:{name}), anuxt.hook('icon:clientBundleIcons', …)insrc/module.ts, an@nuxt/icon2.2.4→2.2.5bump (+minimumReleaseAgeExclude), and docs prose aboutclientBundle/@iconify-json.Decision — no-op
The whole commit is
@nuxt/icon+ iconify machinery, which b24ui doesn't use:@nuxt/icondependency (grep @nuxt/icon package.json pnpm-workspace.yaml→ none; the only mention insrc/module.tsis a commented-out line). So the dep bump / workspace / lockfile changes don't apply.@bitrix24/b24icons-vueVue components, noti-…iconify strings. It has nosrc/theme/icons.tsand nosrc/utils/icons.ts, sogetClientBundleIcons/toBundleNamehave nothing to parse, and there is noicon:clientBundleIconshook to add.@nuxt/icon'sclientBundleembedding +@iconify-json/*collections — porting them would document behavior b24ui doesn't implement, so they're intentionally not carried over.Consistent with the earlier
@nuxt/iconno-ops (#69, #219). Bookkeeping only:.sync/log/8d46034….md— rationale.sync/nuxt-ui.json— reconcile priore4ca579→ PR fix(module): avoid unhead v2-only hookOnce in colors plugin #234 /acb5c96b, add8d46034asno-op, advance cursor🤖 Generated with Claude Code
Generated by Claude Code