Skip to content

chore(sync): no-op upstream @nuxt/icon client-bundle pre-bundling (8d46034)#235

Merged
IgorShevchik merged 1 commit into
mainfrom
sync/nuxt-8d46034
Jul 1, 2026
Merged

chore(sync): no-op upstream @nuxt/icon client-bundle pre-bundling (8d46034)#235
IgorShevchik merged 1 commit into
mainfrom
sync/nuxt-8d46034

Conversation

@IgorShevchik

Copy link
Copy Markdown
Collaborator

Upstream

8d46034feat(module): pre-bundle used icons into @nuxt/icon client bundle

Teaches the module to embed the iconify icons it uses into @nuxt/icon's client bundle at build time — new src/utils/icons.ts (getClientBundleIcons, parsing i-{collection}-{name}{collection}:{name}), a nuxt.hook('icon:clientBundleIcons', …) in src/module.ts, an @nuxt/icon 2.2.42.2.5 bump (+ minimumReleaseAgeExclude), and docs prose about clientBundle/@iconify-json.

Decision — no-op

The whole commit is @nuxt/icon + iconify machinery, which b24ui doesn't use:

  • No @nuxt/icon dependency (grep @nuxt/icon package.json pnpm-workspace.yaml → none; the only mention in src/module.ts is a commented-out line). So the dep bump / workspace / lockfile changes don't apply.
  • b24ui renders icons via @bitrix24/b24icons-vue Vue components, not i-… iconify strings. It has no src/theme/icons.ts and no src/utils/icons.ts, so getClientBundleIcons/toBundleName have nothing to parse, and there is no icon:clientBundleIcons hook to add.
  • The docs paragraphs describe @nuxt/icon's clientBundle embedding + @iconify-json/* collections — porting them would document behavior b24ui doesn't implement, so they're intentionally not carried over.

Consistent with the earlier @nuxt/icon no-ops (#69, #219). Bookkeeping only:

🤖 Generated with Claude Code


Generated by Claude Code

…46034)

Upstream 8d46034 teaches the module to embed the iconify icons it uses into
@nuxt/icon's client bundle. b24ui has no @nuxt/icon dependency and renders icons
via @bitrix24/b24icons-vue components (no iconify strings, no theme/icons.ts),
so there is nothing to port — bookkeeping only.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JS8ypVfQSFzYVZzkTHhURb
@IgorShevchik IgorShevchik merged commit d57802d into main Jul 1, 2026
1 check passed
@IgorShevchik IgorShevchik deleted the sync/nuxt-8d46034 branch July 1, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants