Improve parser correctness and performance - #37
Merged
Conversation
ECorreia45
marked this pull request as ready for review
July 26, 2026 22:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the shared-regex parser with a reentrant single-pass scanner, improve the lightweight DOM implementation, add regression coverage for reproduced parser failures, and include a reproducible before/after benchmark.
Why
The previous parser passed its existing tests but failed several important cases:
>inside quoted attributes broke tokenizationstylebecame elementsparse()calls from callbacks corrupted the outer parseModule-level regex state, dynamic regex creation, remaining-document slices for scripts, namespace caches keyed only by tag name, and repeated Set-to-array conversion also added avoidable overhead.
What changed
benchmark.compare.mjsfor paired baseline/optimized measurementsBenchmark
Node 24, seven paired median samples, alternating before/after order with explicit GC between samples.
The bundled parser increased from 11,212 bytes to 13,715 bytes (+22.3%). This is the main tradeoff to review.
Validation
--noEmitpassesgit diff --checkpasses