Use #' for function references#206
Merged
Merged
Conversation
Sharp-quote the plain-quoted function symbols passed to mapcar, sort, mapconcat and to Helm source slots (candidates-process, match, persistent-action, action-transformer, ...) so the byte-compiler can check they name real functions. Also call `run-with-timer' directly instead of through a pointless `funcall'. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharp-quote the plain-quoted function symbols passed to
mapcar,sort,mapconcatand to the Helm source slots (candidates-process,filter-one-by-one,persistent-action,action-transformer,match) so the byte-compiler can verify they name real functions. Also drops a pointlessfuncallaroundrun-with-timer. Every converted symbol was checked to befboundp(and not a variable), so there's no behavior change.M-x checkdocwarnings