Extract the remote virtual-Dired guard into a macro#205
Merged
Conversation
`helm-projectile-dired-files-new-action', `-add-action' and `-delete-action' each opened with the same six-line check that bails out with a message when the project root is remote and virtual Dired is disabled. Move it into a `helm-projectile--with-virtual-dired' macro so the guard lives in one place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three virtual-Dired actions (
helm-projectile-dired-files-new-action,-add-action,-delete-action) each opened with the same six-line guard that bails out with a message when the project root is remote andhelm-projectile-virtual-dired-remote-enableis nil. Pull it into ahelm-projectile--with-virtual-diredmacro so the check lives in one place.Pure refactor. A small test covers the macro's three cases (local, remote-disabled, remote-enabled).
M-x checkdocwarnings