Small modernization and robustness cleanups#204
Merged
Conversation
- Remove known projects through Projectile's public `projectile-remove-known-project' rather than editing `projectile-known-projects' and calling `projectile-save-known-projects' directly, so helm-projectile stays correct if Projectile changes how it stores that list. - Switch the projectile keybinding setup from `eval-after-load' to the cleaner `with-eval-after-load', dropping the quoted `progn'. - Promote `helm-projectile-virtual-dired-remote-enable' from a plain `defvar' to a boolean `defcustom'; it's a user-facing toggle the code even names in a message, so it belongs in Customize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small, independent cleanups shaken out of the review:
Remove known projects through Projectile's public
projectile-remove-known-projectinstead of editingprojectile-known-projectsand callingprojectile-save-known-projectsdirectly. Keeps us correct if Projectile changes how it stores that list.Switch the
C-c p hkeybinding setup fromeval-after-loadto the cleanerwith-eval-after-load.Promote
helm-projectile-virtual-dired-remote-enablefrom adefvarto a booleandefcustomso it's editable via Customize.The commits are consistent with our contribution guidelines
The new code is not generating bytecode or
M-x checkdocwarningsYou've updated the changelog
You've updated the readme (no user-facing behavior change)