Skip to content

fix: make Linux package installs opt-in - #28

Merged
barbatdev merged 1 commit into
mainfrom
fix/linux-package-install-opt-in
Jul 3, 2026
Merged

fix: make Linux package installs opt-in#28
barbatdev merged 1 commit into
mainfrom
fix/linux-package-install-opt-in

Conversation

@barbatdev

Copy link
Copy Markdown
Owner

Adds safe Linux package install support to the installer while keeping tests isolated from package and external installer side effects.

What changed

  • add Linux package install paths for Homebrew, apt, dnf, and pacman
  • require interactive confirmation by default, or allow opt-in with CORTEX_DOTS_INSTALL_PACKAGES=true
  • skip automatic package installs in non-interactive runs
  • skip package and external installers in tests
  • isolate Ghostty process detection in tests with CORTEX_DOTS_GHOSTTY_PROCESS_NAME

QA

  • local oss-audit
  • invalid regex fail-closed
  • bash/zsh syntax
  • shellcheck severity=error
  • installer tests: copy/symlink/stale-opposite, dry-run, install --check
  • innit02 dry-run and copy/symlink tests passed
  • security review clear with no findings

Review focus

  • review install.sh package install gating and Linux package manager handling
  • review scripts/test-install.sh test isolation flags and Ghostty process override
  • out of scope: unrelated installer cleanup or broader package mapping changes

@barbatdev
barbatdev merged commit 14ea7f9 into main Jul 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants