fix(webkit): [ENG-47033] bound the Panel shell so its own body can scroll - #835
Open
herbert-julio-azion wants to merge 2 commits into
Open
fix(webkit): [ENG-47033] bound the Panel shell so its own body can scroll#835herbert-julio-azion wants to merge 2 commits into
herbert-julio-azion wants to merge 2 commits into
Conversation
herbert-julio-azion
changed the title
herbert-julio-azion
force-pushed
the
fix/ENG-47033-panel-scroll
branch
from
July 31, 2026 14:31
f47d2e3 to
16ee801
Compare
robsongajunior
previously approved these changes
Aug 3, 2026
herbert-julio-azion
changed the title
herbert-julio-azion
marked this pull request as ready for review
August 3, 2026 17:20
…erts The test covering the no-ScrollArea branch was called "renders content as a plain scrollable div when no drawer scroll host is present". It checks the tag name and the absence of the ScrollArea, and nothing about scrolling, so the name promised a guarantee the test never provided. Renamed to state the branch it verifies, with a note on why scroll is not measurable in this suite: the browser env loads no theme CSS and runs no Tailwind (see src/test/setup.ts), so the utility classes never apply and any scroll measurement here would be a false negative. Scrolling is exercised through Drawer and Dialog, the two contexts that mount this shell.
…roll The shell declared `overflow-hidden` with no height bound, so it grew to fit its content instead of clipping it, and `panel-content`'s `overflow-y-auto` never had anything to scroll. Measured inside a 400px-tall container the shell rendered 771px tall with the body not scrolling; with `max-h-full` it is 400px and the body scrolls. Dialog and Drawer already bound the panel from the outside, so this changes only the case where nothing else does. Their 45 tests pass unchanged.
herbert-julio-azion
force-pushed
the
fix/ENG-47033-panel-scroll
branch
from
August 4, 2026 13:51
64ec2c1 to
539933e
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ENG-47033.
The bug
Panelis the shellDialogandDrawerboth render their box with. It declaredoverflow-hiddenwith no height bound, so it grew to fit its content instead ofclipping it, and
panel-content'soverflow-y-autonever had anything to scroll.Measured inside a 400px-tall container: the shell rendered 771px tall with the body
not scrolling. With
max-h-fullit is 400px and the body scrolls.The change
One class on the shell:
max-h-full, which is what makes the existingoverflow-hiddenmean something.Scope, honestly
DialogandDraweralready bound the panel from the outside, so this changes onlythe case where nothing else does. There is no visible difference in either of them,
and no story to point at:
Panelis not a component a consumer reaches for directly,it is the box those two assemble. Its value here is that the shell no longer depends on
its host remembering to cap it.
The other commit renames a Panel test so its name states what it asserts (it was called
"renders content as a plain scrollable div", but the suite cannot observe scrolling: the
browser-mode setup deliberately loads no Tailwind, so any layout assertion there is a
false negative).
Verified
Panel + Dialog + Drawer: 45 tests pass. No visual baseline moved.