Fix uninitialized payloadArray in createPayloadForVP8 error path#2293
Open
YPandas wants to merge 2 commits into
Open
Fix uninitialized payloadArray in createPayloadForVP8 error path#2293YPandas wants to merge 2 commits into
YPandas wants to merge 2 commits into
Conversation
added 2 commits
May 20, 2026 17:43
Move MEMSET before CHK so that payloadArray is zeroed even when input validation fails early, preventing garbage values from being written to output parameters.
Test triggers the error path where payloadBuffer is non-NULL but pData is NULL, verifying output parameters are zeroed instead of containing uninitialized stack values.
sirknightj
approved these changes
May 22, 2026
Ahhorse1
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
MEMSET(&payloadArray, 0, SIZEOF(payloadArray))before input validation increatePayloadForVP8()Why was it changed?
payloadBufferis non-NULL butpDatais NULL, theCHKmacro jumps toCleanUpbeforepayloadArrayis initialized. The cleanup code only zeroes the struct whensizeCalculationOnlyis true, so in this path uninitialized stack values are written to*pPayloadLengthand*pPayloadSubLenSize. Detected by clang static analyzer (scan-build).How was it changed?
MEMSETto before theCHKinRtpVP8Payloader.cso the struct is always zeroed regardless of which branch the error path takes.What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.