tests: unskip three tests in train#5894
Open
lucasjia-aws wants to merge 3 commits into
Open
Conversation
lucasjia-aws
changed the title
The MPI driver script used absolute imports (from sagemaker.train.container_drivers...) which fail at runtime in the training container because sagemaker-train is not installed there. The driver scripts are copied to /opt/ml/input/data/sm_drivers/ and executed directly by the container entrypoint. Changed to sys.path-based relative imports matching the pattern used by torchrun_driver.py, which works correctly in the container environment.
Remove cross-account dependency in test_benchmark_evaluation_nova_model by replacing resources from account 052150106756 with our test account (729646638167) in us-east-1. Also removed mlflow_tracking_server_arn since no MLflow server exists in us-east-1. Test remains skipped pending us-east-1 test infrastructure migration to a dedicated test account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.