Quote NINJA_KUBECONFIG when writing kubeconfig#213
Merged
Conversation
Unquoted `echo ${NINJA_KUBECONFIG}` word-splits the multi-line YAML on
whitespace, collapsing newlines into spaces and producing an invalid
kubeconfig (`yaml: mapping values are not allowed in this context`).
Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit 23ebd4c): https://appscode-v3-hugo--pr213-fix-kubeconfig-quoti-i0iry0kz.web.app (expires Thu, 11 Jun 2026 12:59:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1720b7810a846fabdac7ca3b944d0f3a577e94de |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${NINJA_KUBECONFIG}inrelease.ymlanddeploy.ymlso the multi-line YAML keeps its newlines when written to~/.kube/config.The unquoted
echo ${NINJA_KUBECONFIG}was word-splitting the secret on whitespace, collapsing newlines into spaces. That produced an invalid kubeconfig and caused thev2026.6.12 Releaserun to fail in "Deploy to QA":Ref: https://github.com/appscode/website/actions/runs/26952089345/job/79522602913
Test plan
kubectl get nodessucceeds in "Deploy to QA".