Skip to content

Send User-Agent header on registry requests#766

Open
Rohithmatham12 wants to merge 1 commit into
apple:mainfrom
Rohithmatham12:fix/registry-user-agent
Open

Send User-Agent header on registry requests#766
Rohithmatham12 wants to merge 1 commit into
apple:mainfrom
Rohithmatham12:fix/registry-user-agent

Conversation

@Rohithmatham12

Copy link
Copy Markdown

Summary

  • add a default User-Agent header to RegistryClient requests using the existing clientID value
  • keep an explicitly supplied User-Agent header when callers provide one
  • cover default and explicit User-Agent header behavior in registry client tests

Fixes apple/container#1583.

Testing

  • git diff --check
  • swift test --filter requestHeaders (blocked locally: package requires Swift tools 6.2.0, installed Swift is 6.0.3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: User-Agent header is not being sent in HTTP/1.1 requests to Docker registries

1 participant