feat: add custom home mount path support for container machines#1714
Open
Jonathan5643 wants to merge 1 commit into
Open
feat: add custom home mount path support for container machines#1714Jonathan5643 wants to merge 1 commit into
Jonathan5643 wants to merge 1 commit into
Conversation
Add a new homeMountPath field to MachineConfig, allowing users to customize the host directory mounted as the home directory in container machines. - MachineConfig: homeMountPath: String with defaultHomeMountPath - MachineCreate: new --home-mount-path CLI flag - MachinesService: passes through and uses custom path at boot This enables: container machine create --home-mount-path /custom/path ... container machine set home-mount-path=/custom/path [machine] homeMountPath = "/custom/path" in config.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Add a new
homeMountPathfield toMachineConfig, allowing users to customize the host directory mounted as the home directory in container machines.The
homeMountoption only controls the mount mode (ro/rw/none) for the user's home directory, but provides no way to mount a different host directory. This change adds ahomeMountPathproperty that lets users specify which host directory to mount, with the existing home directory as the default when unset.Users can configure the custom mount path through two entry points:
container machine create --home-mount-path <path>container machine set home-mount-path=<path>Testing