Verify kernel archive SHA-256 digests#1703
Open
haoruilee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Closes #1687
The default kernel archive is downloaded from a remote release URL during first-run setup and via
container system kernel set --recommended. Previously, the archive contents were not verifiedafter download, so integrity depended only on HTTPS and the release artifact remaining unchanged.
This change adds Homebrew-style
url + sha256verification for kernel archives. The recommended/default kernel now has a pinned SHA-256 digest, andcontainer system kernel set --taraccepts--sha256so custom local or remote tar archives can be verified before unpacking and installation.Testing
Validated on macOS:
swift test --filter KernelServiceTestspassedswift test --filter ConfigurationLoaderTestspassedcontainer system kernel set --tar <remote-url> --binary <path> --sha256 <digest>succeeded and containers ran successfully