Skip to content

fix: Remove extra sleep in ImpitHttpClient.stream #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pijukatel merged 1 commit into from
Jun 19, 2026
+0 −5
Merged

fix: Remove extra sleep in ImpitHttpClient.stream #1980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/crawlee/http_clients/_impit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,11 +220,6 @@ async def stream(
try:
yield _ImpitResponse(response)
finally:
# TODO: https://github.com/apify/impit/issues/242
# Quickly closing Response while reading the response body causes an error in the Rust generator in `impit`.
# With a short sleep and sync closing, the error does not occur.
# Replace with `response.aclose` when this is resolved in impit.
await asyncio.sleep(0.01)
response.close()

def _get_client(self, proxy_url: str | None, cookie_jar: CookieJar | None) -> AsyncClient:
Expand Down
Loading