Skip to content

docs: unify crawl caps and fix the runnable code examples#1002

Open
vdusek wants to merge 2 commits into
masterfrom
fix/docs-runnable-examples
Open

docs: unify crawl caps and fix the runnable code examples#1002
vdusek wants to merge 2 commits into
masterfrom
fix/docs-runnable-examples

Conversation

@vdusek

@vdusek vdusek commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Fixes the "Run on Apify" examples in the Python SDK guides.

  • Lower the page cap from 50 to 10 across all crawling examples, so the browser-based ones finish within the 180s runnable-demo timeout.
  • Selenium: slim the runnable example to a plain crawler (the full version was too large to encode into the Run-on-Apify URL and failed with HTTP 414), and move the proxy-auth extension into the "Using Apify Proxy" section as a separate, non-runnable extension snippet.
  • Browser Use: make it non-runnable (it needs an LLM API key the shared runner cannot provide), with a comment explaining why. Same note added to the Scrapy and Scrapling-browser examples.
  • Keep both Scrapling examples runnable.
  • Pydantic: log a readable validation summary and fail cleanly via Actor.fail instead of re-raising into a raw traceback.

Lower the page cap from 50 to 10 across all crawling examples so the browser-based ones finish within the runnable-demo timeout. Make Selenium (snippet too large for the Run-on-Apify URL) and Browser Use (needs an LLM API key) non-runnable with explanatory comments, keep both Scrapling examples runnable, and have the Pydantic example fail cleanly via `Actor.fail` instead of re-raising into a raw traceback.
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jun 18, 2026
@vdusek vdusek self-assigned this Jun 18, 2026
@github-actions github-actions Bot added this to the 143rd sprint - Tooling team milestone Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.46%. Comparing base (53122e4) to head (8a854f2).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
- Coverage   90.51%   90.46%   -0.06%     
==========================================
  Files          49       49              
  Lines        3132     3135       +3     
==========================================
+ Hits         2835     2836       +1     
- Misses        297      299       +2     
Flag Coverage Δ
e2e 36.10% <ø> (-0.04%) ⬇️
integration 57.06% <ø> (-0.06%) ⬇️
unit 79.23% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek marked this pull request as ready for review June 18, 2026 13:08
@vdusek vdusek requested a review from szaganek as a code owner June 18, 2026 13:08
@vdusek vdusek changed the title docs: unify crawl caps and fix runnable examples docs: unify crawl caps and fix the runnable code examples Jun 18, 2026
@vdusek vdusek requested a review from Pijukatel June 18, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants