Skip to content

test: deflake request queue aliases e2e test #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vdusek wants to merge 1 commit into from
+5 −2
Closed

test: deflake request queue aliases e2e test #1000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/e2e/test_actor_request_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,11 @@ async def main() -> None:
assert rq_2.name is None

if not was_rebooted:
await rq_1.add_request(Request(url='https://example.com/rq_1', unique_key='rq_1'))

@Pijukatel Pijukatel Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth adding retries to the add_request to be consistent with add_requests

await rq_2.add_request(Request(url='https://example.com/rq_2', unique_key='rq_2'))
# The platform's batch-add endpoint is best-effort: a single `add_request` can come back
# unprocessed (returns `None`) without retrying. Use `add_requests`, which retries unprocessed
# requests, so the reboot below never loses a request and the post-reboot fetch is reliable.
await rq_1.add_requests([Request(url='https://example.com/rq_1', unique_key='rq_1')])
await rq_2.add_requests([Request(url='https://example.com/rq_2', unique_key='rq_2')])
await Actor.set_value('was_rebooted', value=True)
await Actor.reboot()

Expand Down