fix: Only log any error that happens during log redirection#866
Merged
Conversation
github-actions
Bot
added
the
t-tooling
Pijukatel
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #866 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 48 48
Lines 5069 5072 +3
=======================================
+ Hits 4790 4793 +3
Misses 279 279
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pijukatel
force-pushed
the
only-log-errors-on-log-redirection
branch
from
e5b7d79 to
ac80143
Compare
barjin
approved these changes
Jun 18, 2026
Member
There was a problem hiding this comment.
lgtm, tested as part of triaging apify/impit#482 👍
Thank you, @Pijukatel !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(This was hidden by a bug in impit, which is going to be fixed soon and it would lead to similar issue observed in JS client
actor.call()with log streaming throws network error on long runs apify-client-js#873)~onimpitand pin to the latest version0.12.0. Zero versioned releases can have breaking changes even in minor versions. Bumping impit version to new minor version should be an intentional action. (Expected release of impit0.13.0would break client without this change)Issues
Closes: #864