Skip to content

[TODO]: update generated models from apify-docs PR #2622#860

Closed
apify-service-account wants to merge 1 commit into
masterfrom
update-models-docs-pr-2622
Closed

[TODO]: update generated models from apify-docs PR #2622#860
apify-service-account wants to merge 1 commit into
masterfrom
update-models-docs-pr-2622

Conversation

@apify-service-account

Copy link
Copy Markdown
Contributor

This PR updates the auto-generated Pydantic models and TypedDicts based on OpenAPI specification changes in apify-docs PR #2622.

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.49%. Comparing base (9a953c7) to head (8240742).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/apify_client/_typeddicts.py 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
- Coverage   94.82%   94.49%   -0.34%     
==========================================
  Files          48       48              
  Lines        5045     5069      +24     
==========================================
+ Hits         4784     4790       +6     
- Misses        261      279      +18     
Flag Coverage Δ
integration 92.62% <33.33%> (-0.58%) ⬇️
unit 83.27% <33.33%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek self-requested a review June 17, 2026 11:11
@vdusek

vdusek commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

false positive, triggered by merging the master commit to PR

@vdusek vdusek closed this Jun 17, 2026
vdusek added a commit that referenced this pull request Jun 17, 2026
…861)

The `Regenerate models` workflow opened
[#860](#860),
duplicating webhook fields already merged via
[#855](#855). The **Set
up branch** step regenerated on top of a stale
`update-models-docs-pr-<N>` branch (based on a pre-#855 `master`), so an
already-merged change reappeared as a fresh diff.

Fix: always regenerate against the current `master`.

- **Check for model changes** compares the regenerated files against
`master` and skips when there is no diff, so an already-merged change
can no longer produce a duplicate PR.
- When there is a diff, the branch is force-pointed at `master` and
`signed-commit` adds one regenerated commit on top. The PR still updates
whenever the source docs PR gets new commits.

Trade-off: the branch is always a single regenerated commit on top of
`master`, so any commits pushed onto it directly are replaced on the
next run. This is the intended, idempotent behavior for an
auto-generated branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants