Skip to content

test(api): fix flaky build-tag tests by waiting for terminal build status #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
l2ysho wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −13
Open

test(api): fix flaky build-tag tests by waiting for terminal build status #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94f9427
test(api): fix flaky build-tag tests by waiting for terminal build st…
l2ysho Jun 15, 2026
3ff259b
test(api): drop redundant async and non-null assertions
l2ysho Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions test/__setup__/build-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,10 @@
import type { ApifyClient } from 'apify-client';

import { ACTOR_JOB_STATUSES } from '@apify/consts';

/**
* Waits for the build to finish
*/
export const waitForBuildToFinish = async (client: ApifyClient, buildId: string) => {
while (true) {
const build = await client.build(buildId).get();
if (build!.status !== (ACTOR_JOB_STATUSES.RUNNING as unknown)) return build;
await new Promise((resolve) => {
setTimeout(resolve, 2500);
});
}
export const waitForBuildToFinish = (client: ApifyClient, buildId: string) => {
return client.build(buildId).waitForFinish();
};

/**
Expand Down
6 changes: 3 additions & 3 deletions test/api/commands/builds/tags.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('[api] apify builds add-tag / remove-tag', () => {

// Build the actor and wait for it to finish
const buildStarted = await testUserClient.actor(testActor.id).build('0.0');
testBuild = (await waitForBuildToFinish(testUserClient, buildStarted.id))!;
testBuild = await waitForBuildToFinish(testUserClient, buildStarted.id);
}, TEST_TIMEOUT);

afterAll(async () => {
Expand Down Expand Up @@ -110,7 +110,7 @@ describe('[api] apify builds add-tag / remove-tag', () => {

// Create another build
const buildStarted2 = await testUserClient.actor(testActor.id).build('0.0');
const testBuild2 = (await waitForBuildToFinish(testUserClient, buildStarted2.id))!;
const testBuild2 = await waitForBuildToFinish(testUserClient, buildStarted2.id);

// Reassign the tag to the new build
await testRunCommand(BuildsAddTagCommand, {
Expand Down Expand Up @@ -169,7 +169,7 @@ describe('[api] apify builds add-tag / remove-tag', () => {
async () => {
// Create another build and tag it
const buildStarted2 = await testUserClient.actor(testActor.id).build('0.0');
const testBuild2 = (await waitForBuildToFinish(testUserClient, buildStarted2.id))!;
const testBuild2 = await waitForBuildToFinish(testUserClient, buildStarted2.id);

await testRunCommand(BuildsAddTagCommand, {
flags_build: testBuild2.id,
Expand Down
Loading