refactor(serializer): move isCacheKeySafe to AbstractItemNormalizer#8200
Open
soyuka wants to merge 3 commits into
Open
refactor(serializer): move isCacheKeySafe to AbstractItemNormalizer#8200soyuka wants to merge 3 commits into
soyuka wants to merge 3 commits into
Conversation
`#[ApiProperty(security: ...)]` makes allowed attributes per-user, but the local `componentsCache` in JsonApi and Hal item normalizers is not user-aware: a cached component map can leak attributes across users. Move `isCacheKeySafe()` from `GraphQl/Serializer/ItemNormalizer` into `Serializer/AbstractItemNormalizer` so it is shared across all formats, and gate `$context['cache_key']` with it in JsonApi and Hal. Promote `CacheKeyTrait::getCacheKey()` from `private` to `protected` so subclasses can reuse the inherited trait method. Supersedes api-platform#7854.
- Bump api-platform/serializer min to ^4.3.7 in JsonApi, Hal and GraphQl composer.json so they pull a serializer release that exposes the new protected isCacheKeySafe() method on AbstractItemNormalizer. - Change createCacheKeySafeProbe() return type to object so PHPStan can resolve probeIsCacheKeySafe() on the anonymous AbstractItemNormalizer subclass.
soyuka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal refactor moving the cache-key safety check to the base normalizer so it is shared across formats. Adds unit-test coverage.
Holding for review.