Fix for WICKET-7182#1477
Merged
Merged
Conversation
…t call on the autocomplete extension
martin-g
reviewed
Jun 4, 2026
| if (document.activeElement !== input) { | ||
| ignoreOneFocusGain = true; | ||
| input.trigger('focus'); | ||
| jQuery(input).trigger('focus'); |
Member
There was a problem hiding this comment.
Better use https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus
All major browsers support it.
Contributor
Author
There was a problem hiding this comment.
True, but then it would be better to upgrade the whole style of the script. This keeps the same style as with the other calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapped the fetched element with jQuery to use the event call, like with other calls on the script.