[MINOR][TEST] Add Asserts to ScalarIOTest for Result Validation#2522
Merged
Conversation
…the test success uncomment some checks for correct results refactor(test/functions/io/ScalarIOTest.java): remove unnecessary indents
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2522 +/- ##
============================================
+ Coverage 71.56% 71.62% +0.06%
- Complexity 49110 49257 +147
============================================
Files 1575 1579 +4
Lines 189793 190286 +493
Branches 37235 37319 +84
============================================
+ Hits 135816 136292 +476
- Misses 43480 43487 +7
- Partials 10497 10507 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thank you very much @Baunsgaard :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the ScalarIOTest by adding respective asserts to validate the output and uncommenting checks about the variables written to disk.
Additionally, some unnecessary indents in the test class are removed.