Skip to content

[#2804] bugfix: fix login() once again accepts null subject #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lprimak wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

[#2804] bugfix: fix login() once again accepts null subject #2807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/shiro/mgt/DefaultSecurityManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ public Subject login(Subject subject, AuthenticationToken token) throws Authenti
* @param subject Subject
*/
protected void beforeSuccessfulLogin(Subject subject) {
Session session = subject.getSession(false);
Session session = subject != null ? subject.getSession(false) : null;
Comment thread
lprimak marked this conversation as resolved.
if (session != null) {
Map<Object, Object> attributes = new HashMap<>();
session.getAttributeKeys().forEach(key -> attributes.put(key, session.getAttribute(key)));
Expand Down
Loading