[ISSUE 57] add rocketmq api - #63
Conversation
4b07bd0 to
6b7520f
Compare
|
@linjiemiao ping, could you please help to resolve the conflict. |
Okay, I will cherry-pick your latest commit, and then I resolve the conflict. |
|
still need this |
|
This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts: git fetch origin
git checkout issue-57-dev
git rebase origin/main
# resolve conflicts, then:
git push --force-with-leaseThis is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved. Automated notification by github-manager-bot |
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR modifies 10 file(s) with 1043 lines of diff. No test changes detected — consider adding test coverage.
Automated review by github-manager-bot
Additional notes (not anchored to a changed line)
- [INFO]
README.md:1— Large diff (1043 lines). Consider breaking into smaller, focused PRs for easier review. (line outside diff)
| @@ -33,7 +33,7 @@ type BrokerSpec struct { | |||
| // Add custom validation using kubebuilder tags: https://book-v1.book.kubebuilder.io/beyond_basics/generating_crd.html | |||
There was a problem hiding this comment.
No test changes detected alongside source modifications. Consider adding tests to cover the changes.
add rocketmq api