[ISSUE #50] Feature add rocketmq exporter to nameserver - #51
Conversation
feature add rocketmq-exporter to cluster
|
Thanks for your contribution~
|
Design: If the exporter is used as an independent pod, when I have multiple nameservers, my exporter does not know which nameserver to connect, so I use exporter as an option of nameserver, deploy it as a sidecar to nameserver。Can you give me some design advice? |
In fact operator maintains a variable in the shared package named |
2) add how to user rocketmq-exporter
…etmq-operator into feature-code-review
ADD exporter image and document. Please check it. I tend to use the exporter as the sidecar of the nameserver. Please check the exporter's dockerfile. Because I tend to adjust the fields in the share package to private, so that multiple clusters can be deployed using one operator. If you still want to deploy the exporter separately, I will do as you say. thanks |
| - name: ROCKETMQ_VERSION | ||
| value: V4_3_2 | ||
| - name: NAMESRV_ADDR | ||
| value: 127.0.0.1:9876 |
There was a problem hiding this comment.
I think it better to init the NAMESRV_ADDR env in nameservice_controller.go
|
This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts: git fetch origin
git checkout feature-code-review
git rebase origin/main
# resolve conflicts, then:
git push --force-with-leaseThis is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved. Automated notification by github-manager-bot |
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR modifies 10 file(s) with 670 lines of diff. No test changes detected — consider adding test coverage.
Automated review by github-manager-bot
Additional notes (not anchored to a changed line)
- [INFO]
README.md:1— Large diff (670 lines). Consider breaking into smaller, focused PRs for easier review. (line outside diff)
| @@ -49,6 +49,17 @@ type NameServiceSpec struct { | |||
| HostPath string `json:"hostPath"` | |||
There was a problem hiding this comment.
No test changes detected alongside source modifications. Consider adding tests to cover the changes.
No description provided.