feat: add write builder configuration#367
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #232.
The current write path configures some writer behavior after creating
TableWrite, whileTableCommitis created independently from the sameWriteBuilder. This makes builder-level write configuration incomplete and prevents writers and committers from sharing an explicit commit user.Brief change log
WriteBuilder::with_commit_userso writers and committers created from the same builder share the same commit user.WriteBuilder::with_overwriteand route DataFusion overwrite writers through the builder instead of mutatingTableWriteafter creation.Tests
cargo test -p paimon table::write_buildercargo test -p paimon table::table_writecargo test -p paimon table::table_commitcargo test -p paimon-datafusion table::tests::test_insert_overwriteAPI and Format
Adds public
WriteBuilderAPIs:commit_user,with_commit_user, andwith_overwrite.No storage format change.
Documentation
Public API doc comments document the
commit_usersemantics and validation requirements.