KNOX-3347 - Introduce TokenExchangePrincipal for extending Act claim …#1262
Open
lmccay wants to merge 1 commit into
Open
KNOX-3347 - Introduce TokenExchangePrincipal for extending Act claim …#1262lmccay wants to merge 1 commit into
lmccay wants to merge 1 commit into
Conversation
…for token_exchange
Test Results22 tests 22 ✅ 1s ⏱️ Results for commit 436a102. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-1234 - Introduce TokenExchangePrincipal for extending Act claim for token_exchange
What changes were proposed in this pull request?
Currently, the ActorChainPrincipal includes whatever act chain was in the Subject token from the token_exchange. The presence of the ImpersonatedPrincipal is currently only added by the identity assertion provider based on a doAs and proxyuser based impersonation. This is required for the new actor to be added to the nested 'act' claim.
Let's add the use of the TokenExchangePrincipal by the identity assertion logic that sets the ImpersonatedPrincipal in addition to the doAs pattern.
We also have to keep the existing principal mapping logic intact so that the token exchange reflects the mapped principal as appropriate even when not the principal requested in the token_exchange request.
Also, be sure that the actor token is being properly validated.
How was this patch tested?
Existing tests run and new tests added.
Manually tested as well.