Skip to content

Load: Stablized the IoTDBLoadTsFileWithModIT#17730

Open
Caideyipi wants to merge 1 commit into
masterfrom
load-it
Open

Load: Stablized the IoTDBLoadTsFileWithModIT#17730
Caideyipi wants to merge 1 commit into
masterfrom
load-it

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@luoluoyuyu luoluoyuyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review 总结

针对 async load 后 show databases 在集群各 DN 元数据传播不同步导致 InconsistentDataException 的 flake 修复合理:捕获后重试 + 正确 interrupt 处理。

建议合入

break;
}
}
} catch (InconsistentDataException ignored) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

捕获 InconsistentDataExceptionignored 重试是合理的 workaround。

建议(非阻塞):若 InconsistentDataException 持续 10 次仍失败,最终 Assert.assertTrue(databaseFound) 的错误信息不会提及不一致原因,排障较难。可考虑在最后一次失败时 wrap 并附带 retry 次数,或使用 Awaitility 统一重试逻辑(与项目其他 IT 一致)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants