Conversation
|
luoluoyuyu
approved these changes
May 27, 2026
Member
luoluoyuyu
left a comment
There was a problem hiding this comment.
Review 总结
针对 async load 后 show databases 在集群各 DN 元数据传播不同步导致 InconsistentDataException 的 flake 修复合理:捕获后重试 + 正确 interrupt 处理。
建议合入。
| break; | ||
| } | ||
| } | ||
| } catch (InconsistentDataException ignored) { |
Member
There was a problem hiding this comment.
捕获 InconsistentDataException 后 ignored 重试是合理的 workaround。
建议(非阻塞):若 InconsistentDataException 持续 10 次仍失败,最终 Assert.assertTrue(databaseFound) 的错误信息不会提及不一致原因,排障较难。可考虑在最后一次失败时 wrap 并附带 retry 次数,或使用 Awaitility 统一重试逻辑(与项目其他 IT 一致)。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR