docs: add Iceberg security model#688
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds repository-level guidance for security triage in Apache Iceberg C++, defining the project’s security boundaries for maintainers and automated scanners.
Changes:
- Adds a detailed Iceberg C++ security threat model.
- Adds
AGENTS.mdto direct automated agents to the threat model.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
SECURITY-THREAT-MODEL.md |
Defines security goals, roles, trust boundaries, in-scope vulnerabilities, out-of-scope categories, and scanner calibration rules. |
AGENTS.md |
Points automated agents to the new security threat model as the authoritative reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RussellSpitzer
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to: apache/iceberg#16538
This PR publishes a security model for Iceberg and adds a detailed threat model referenced from AGENTS.md so there is a clear project reference for how Iceberg distinguishes security issues from other bugs.
The goal is to make Iceberg’s security boundaries explicit for both human triage and automated scanning, and to reduce false positives in future security reporting.
This PR was drafted with AI assistance and then manually reviewed and edited to reflect the project’s current approach to security roles, trust boundaries, and the handling of recent security reports.
Note:
AGENTS.mdis currently in.gitignore, but this file was force committed to ensure that agents running automated security scans will be able to find the security model.