-
Notifications
You must be signed in to change notification settings - Fork 626
fix(bin): replace lsof port preflight with ss/netstat #3105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bitflicker64
wants to merge
10
commits into
apache:master
Choose a base branch
from
bitflicker64:fix/lsof-port-check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
30bf975
fix(dist): replace lsof-based port check with ss/netstat//dev/tcp fal…
bitflicker64 bf0dd03
fix(bin): polish server util helpers after lsof port-check review
bitflicker64 263d818
fix(bin): converge check_port on a conservative port-only preflight
bitflicker64 d58a983
docs(bin): record the port-preflight tradeoffs, and fix userinfo parsing
bitflicker64 cd9f8c2
fix(bin): reject oversized ports before arithmetic conversion
bitflicker64 e993c4b
fix(bin): give the shipped images a working port preflight
bitflicker64 5264ecf
fix(bin): revert PD/Store helper contracts and drop their dead lsof dep
bitflicker64 1709d90
fix(bin): close remaining port preflight review gaps
bitflicker64 8a64a1f
test(bin): enforce port preflight contracts
bitflicker64 09dbc74
fix(server): stabilize port deadline tests
imbajin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.