fix(tests): tolerate numpy pre-release versions in test_node#1627
Merged
Conversation
jernejfrank
approved these changes
Jun 7, 2026
jernejfrank
left a comment
Contributor
There was a problem hiding this comment.
Was just looking at this, you beat me to it :)
Contributor
|
@ArnavBalyan can you still fix the one broken test for py3.12+? Seems a np dtype mismatch |
Member
Author
|
1 sec thanks for flagging checking |
7fd48a8 to
ccc3da2
Compare
Member
Author
|
CI is green now ty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
.which fails on annotated versions like2.5.0rc1.Versionto avoid thisHow I tested this
Notes
Checklist