Skip to content

fix(tests): tolerate numpy pre-release versions in test_node#1627

Merged
jernejfrank merged 1 commit into
apache:mainfrom
ArnavBalyan:arnavb/fix-np-failure
Jun 7, 2026
Merged

fix(tests): tolerate numpy pre-release versions in test_node#1627
jernejfrank merged 1 commit into
apache:mainfrom
ArnavBalyan:arnavb/fix-np-failure

Conversation

@ArnavBalyan

Copy link
Copy Markdown
Member

Changes

  • Tests fail due to manual split of np version on . which fails on annotated versions like 2.5.0rc1.
  • Move to packaging Version to avoid this

How I tested this

  • CI

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@jernejfrank jernejfrank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just looking at this, you beat me to it :)

@jernejfrank

Copy link
Copy Markdown
Contributor

@ArnavBalyan can you still fix the one broken test for py3.12+? Seems a np dtype mismatch

@ArnavBalyan

Copy link
Copy Markdown
Member Author

1 sec thanks for flagging checking

@ArnavBalyan ArnavBalyan force-pushed the arnavb/fix-np-failure branch from 7fd48a8 to ccc3da2 Compare June 7, 2026 15:13
@ArnavBalyan

Copy link
Copy Markdown
Member Author

CI is green now ty!

@jernejfrank jernejfrank merged commit 48108d5 into apache:main Jun 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants