GROOVY-12117: Resolution of inherited static trait method from sub-tr…

[paulk-asert]

…ait body is transform-order dependent

[codecov-commenter]

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.5418%. Comparing base (a7d75a5) to head (056b089).
⚠️ Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
...oovy/transform/trait/TraitReceiverTransformer.java	75.0000%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##               master      #2644        +/-   ##
==================================================
- Coverage     68.5420%   68.5418%   -0.0002%     
- Complexity      33730      33740        +10     
==================================================
  Files            1523       1523                
  Lines          127923     127938        +15     
  Branches        23251      23254         +3     
==================================================
+ Hits            87681      87691        +10     
- Misses          32464      32465         +1     
- Partials         7778       7782         +4     

Files with missing lines	Coverage Δ
...oovy/transform/trait/TraitReceiverTransformer.java	88.6139% <75.0000%> (-0.2750%)	⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[eric-milles]

I was unable to recreate the order issue with the latest Groovy 6 snapshot. Did this test trip it before the change?

[paulk-asert]

With the fix backed out, the failing case is exactly the added test:

FAIL: testGrailsHelperShapeWithSubTraitDeclaredFirst
[Static type checking] - Cannot find matching method
Arguable#withDelegate(groovy.lang.Closure, Field)

[eric-milles]

Not sure what I missed. I have read over my test case several times and it looks the same...

Anyways, the change itself looks good, so no worries there.