GROOVY-11807: MapWithDefault can break type safety of key set#2641
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2641 +/- ##
==================================================
+ Coverage 68.5420% 68.5476% +0.0055%
- Complexity 33730 33742 +12
==================================================
Files 1523 1523
Lines 127923 127936 +13
Branches 23251 23252 +1
==================================================
+ Hits 87681 87697 +16
+ Misses 32464 32460 -4
- Partials 7778 7779 +1
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds key- and key/value-checked withDefault overloads for Map to prevent MapWithDefault auto-growth from silently inserting keys of an incompatible runtime type (GROOVY-11807), and introduces regression tests covering the new behavior.
Changes:
- Introduce new
DefaultGroovyMethods.withDefault(Map, Class, …)overloads that wrap the backing map withasChecked(...)before decorating withMapWithDefault. - Add a new regression test class verifying incompatible keys/values fail fast (including under
@CompileStatic) while the plainwithDefaultremains lenient.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java | Adds new key-checked and key/value-checked withDefault overloads built on asChecked. |
| src/test/groovy/bugs/Groovy11807.groovy | Adds regression tests for GROOVY-11807 covering dynamic and static compilation scenarios. |
✅ All tests passed ✅🏷️ Commit: a4b448b Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.