[metrics] Fix typo in scanner metric name#3448
Open
charlesdong1991 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The scanner metric constant
SCANNER_LAST_POLL_SECONDS_AGOexposes its value aslastPoolSecondsAgo, but i believe the intended name islastPollSecondsAgo(aka "Poll", not "Pool")Brief change log
Fix the string value of
MetricNames.SCANNER_LAST_POLL_SECONDS_AGOfromlastPoolSecondsAgotolastPollSecondsAgo.NOTE:
This changes a user-facing client scanner metric name. Existing dashboards/alerts referencing
lastPoolSecondsAgowould need to be updated, so kinda breaking change for end users.Let me know if you want this PR to retain compatibiilty instead.