fix: reject nested arrays in array_distance - #23995
Open
2010YOUY01 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23995 +/- ##
==========================================
+ Coverage 80.75% 80.77% +0.02%
==========================================
Files 1096 1096
Lines 373282 373757 +475
Branches 373282 373757 +475
==========================================
+ Hits 301440 301901 +461
+ Misses 53869 53849 -20
- Partials 17973 18007 +34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
See reproducer in
datafusion-cli, nowarray_distance()allows nested list as input, and it will use the 1st inner array to compute the distance.This look like an invalid input, this PR reject nested array in this function
What changes are included in this PR?
At function planning, reject
array_distancewith nested array input argsAre these changes tested?
Yes, slt (plus some extra tests that I found that has not been covered in
codecov)Are there any user-facing changes?