perf: precompile formats in to_time - #23964
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23964 +/- ##
==========================================
+ Coverage 80.66% 80.84% +0.17%
==========================================
Files 1095 1096 +1
Lines 372294 373848 +1554
Branches 372294 373848 +1554
==========================================
+ Hits 300324 302247 +1923
+ Misses 54055 53567 -488
- Partials 17915 18034 +119 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
neilconway
approved these changes
Jul 29, 2026
neilconway
left a comment
Contributor
There was a problem hiding this comment.
Looks great, overall! Nicely targeted and well-written improvement, nice perf win.
neilconway
enabled auto-merge
July 30, 2026 12:25
Contributor
Author
|
Thanks for your review @neilconway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
to_timepreviously parsed the Chrono format strings for every non-null input value. For array inputs, this repeated the same format parsing for each row in a batch.This PR precompiles the format strings once per udf invocation and reuses the compiled format items while parsing each value.
What changes are included in this PR?
Are these changes tested?
Yes. Existing tests pass, and new slt coverage was added for multiple formats and NULL values.
Are there any user-facing changes?
No. This is an internal performance optimization.
Benchmarks