Skip to content

Add commit-code-check script - #35

Merged
amateescu merged 2 commits into
amateescu:mainfrom
mstrelan:feature/commit-code-check
Jul 29, 2026
Merged

Add commit-code-check script#35
amateescu merged 2 commits into
amateescu:mainfrom
mstrelan:feature/commit-code-check

Conversation

@mstrelan

@mstrelan mstrelan commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

The Issue

  • I'm too lazy to type ddev exec core/scripts/dev/commit-code-check.sh

How This PR Solves The Issue

Allows me to type ddev commit-code-check

Manual Testing Instructions

ddev add-on get https://github.com/amateescu/ddev-drupal-dev/tarball/refs/pull/35/head
ddev commit-code-check

Automated Testing Overview

To do, as per phpcs, etc

Release/Deployment Notes

N/A

@rpkoller

Copy link
Copy Markdown
Contributor

It would probably a good idea to also make an addition to the readme so users are aware of the newly added command. and it might be probably also helpful to add a brief note about how and more importantly when to use that command. i was for example completely unaware of the existence of that script and ive simply tried running ddev exec core/scripts/dev/commit-code-check.sh and got There are no files to check. If you have staged a commit use the --cached option. in return. so i assume the script should only be executed on a checked out MR with uncommitted files?

@amateescu

Copy link
Copy Markdown
Owner

Good idea :) I added some instructions and other small fixes.

@amateescu
amateescu merged commit 3da4119 into amateescu:main Jul 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants