You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Categories covered: search, category filters, compare, protection plan comparison, wishlist, cart, store pickup, delivery selection, mock checkout, confirmation, order lookup, rewards, support article search, store amenities, order history, multi-page reasoning.
Screenshot capture was attempted but could not be completed on this machine.
npx playwright install chromium failed with network ECONNRESET, so no review-only screenshots were produced in sites/bestbuy/scraped_data/submission_review/.
HF asset status
Local asset tarball prepared: C:\Users\34475\Desktop\VScode\wh-static-pr-bestbuy\bestbuy.tar.gz
We deployed the environment locally and ran the full review checklist; every finding below was independently reproduced, and fidelity was checked against the real upstream site.
Issues (summary)
BLOCKER: .assets-revision pins 'main' but bestbuy.tar.gz only exists on the HF PR ref -> CI fail-closed
MINOR: Task BestBuy--11 is ill-posed: no deal title mentions a 'big screen event'
MINOR: Answer-leak + single-result: Task 0 (price) readable on results card; product searches return 1 result
MINOR: Port-slot collision with released merriam_webster (both claim slot 15 / :40015)
MINOR: Task 3 amenity leaked on stores list page
Mechanical checks: FAIL
Most mechanics are clean: byte-identical idempotent reset (instance md5 == seed md5 == 71c41f6f..., function-level idempotency gate at seed_data.py:1515), no cross-site imports (from sites./import sites = 0 hits), no AppleDouble files, no scraped_data reads in handlers, .gitignore matches .assetpaths, and py_compile passes on app.py + seed_data.py.
Visual fidelity: FAIL
Brand fidelity is strong: yellow/blue palette (#0046be/#fff200), category nav, hero, deals row, featured grid, store cards, footer.
Functional depth: PASS (with nits)
Every flow was driven live. Login (alice.j@test.com → /account "Jordan"; bad password rejected), register (success + mismatched-password and duplicate-email validation), rewards (alice 1840), wishlist, cart add + reload-persistence, full checkout end-to-end as david producing deterministic order BBY-240061, compare page with alice's 3 seeded items, order lookup/detail.
Task quality: FAIL
19 tasks over a deep, balanced catalog (156 products = 13×12 categories, 25 brands, 15 stores, 24 support articles, 60 orders, 339 reviews, 312 protection plans), so per-category browse distractors are real.
Required fixes before approval
(BLOCKER) Repin .assets-revision from revision: main to the merged HuggingFace dataset SHA that actually contains bestbuy.tar.gz (after HF PR 31 merges).
(MAJOR) Fix _write_svg (seed_data.py:258-292) to XML-escape title/subtitle/badge (xml.sax.saxutils.escape/html.escape) before interpolation; regenerate all SVGs and reseed.
(MAJOR) Fix the Task 0 price leak and the single-result pattern: hide price on result cards for price-answer tasks and/or phrase product tasks with looser queries that return ≥6 results with near-misses, so the answer requires opening the PDP and the agent must disambiguate.
(MAJOR) Resolve the :40015 slot collision with the released merriam_webster: append the later-merged site at index 16 (:40016) and bump EXPOSE 40000-40016 in websyn_start.sh, control_server.py, and Dockerfile.
(MINOR) Repair Task 11's wording/location mismatch: rename deal 14's title/badge to mention "Big Screen Event," or surface product.deal_badge on the /deals page, or reword the task to "find the product tagged Big Screen Event" without constraining it to the deals page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Site name
Best Buy
Site slug
bestbuy
Upstream URLs
Contribution type
New Website
Contributor
XuanRui LI / Lxr-max
Contact email
mingduanmu845@gmail.com
Safety note
Deterministic demo retail data only; no real payment, no real checkout, no live Best Buy calls, no external runtime network calls.
Implementation summary
sites/bestbuy/.bestbuyinwebsyn_start.sh,control_server.py,Dockerfile, and updated repo docs/skill references for the new site count and port range.Seed row counts (instance_seed/bestbuy.db)
Benchmark users
TestPass123!Task count and categories
Selected WebSyn port
40015Key routes
/,/home,/categories,/category/<category_slug>,/products,/product/<sku>,/deals,/stores,/stores/<store_slug>,/support,/search/cart,/cart/add,/checkout,/checkout/shipping,/checkout/pickup,/checkout/payment,/checkout/review,/checkout/confirmation/login,/register,/logout,/account,/account/orders,/account/rewards,/account/wishlist,/order-lookup,/order/<order_number>Verification commands and results
py -3 -m py_compile sites/bestbuy/app.py✅py -3 -m py_compile sites/bestbuy/seed_data.py✅py -3 -m py_compile sites/bestbuy/_health.py✅sites/bestbuy/tasks.jsonl✅ (19 tasks, unique IDs, correctweb_name/web/upstream_urlfields)sites/*/tasks.jsonl, 16 files / 662 tasks total)Docker result
docker build -t webharbor:bestbuy-pr .✅docker run -d --name webharbor-bestbuy-submit -p 8201:8101 -p 41015:40015 webharbor:bestbuy-pr✅ok=trueand all 16 registered sites alive ✅Smoke test result
/,/home,/categories,/products,/cart,/checkout,/order-lookup,/support,/login✅BBY-240061Reset + MD5 result
POST /reset/bestbuyreturnedready=true✅71c41f6f167e00c4b7bf725a1ccf343d /opt/WebSyn/bestbuy/instance/bestbuy.db71c41f6f167e00c4b7bf725a1ccf343d /opt/WebSyn/bestbuy/instance_seed/bestbuy.dbScreenshot paths
npx playwright install chromiumfailed with networkECONNRESET, so no review-only screenshots were produced insites/bestbuy/scraped_data/submission_review/.HF asset status
C:\Users\34475\Desktop\VScode\wh-static-pr-bestbuy\bestbuy.tar.gz--create-prreturned this reference:.assets-revisionwas not modified in this PR.Known limitations
Manual reviewer notes
instance_seed/bestbuy.dband verified via control-plane reset + MD5 matching.