Add AKC mirror site#40
Open
Sun-sunshine06 wants to merge 1 commit into
Open
Conversation
Susan571
suggested changes
Jun 21, 2026
Susan571
left a comment
There was a problem hiding this comment.
Reviewer checklist (WebHarbor Review Guide)
Reviewer note: Source-level review (checked out pull/40/head). The mechanical Docker pipeline (build, curl 200, md5 reset) was not run in my environment — please pair with a Docker-capable mechanical pass.
Visual fidelity: ❌ FAIL
- The most built-out of this contributor's set (app ~522 lines; breed_detail/compare/selector/events/articles; branded AKC header). But breed imagery is the
/breed-art/<slug>.svgplaceholder — real AKC pages are defined by distinctive breed photography, so this fails the real-images check.
Functional depth: ✅ PASS
- Breed browse with group/size filters, breed detail, breed selector with real scoring logic (energy/grooming/apartment matching), compare, expert-advice articles, events with registration, login/register, save-breed, owner-profile update. Trait ratings (energy/grooming 1–5) mirror AKC's real trait scales.
Task quality: ⚠️ Request changes (10 tasks)
- Good:
AKC--1(breed selector: apartment + moderate energy + low grooming → recommend),--2(compare Golden Retriever vs Border Collie energy — decided on the compare page, not leaked),--5(filter events to Training → CGC test city/state),--8(register a dog for a webinar = real state change). - Only 10 tasks (need 15–20);
AKC--3leaks the password; confirm group/temperament answers require the detail page, not the card.
Verdict: Request changes
(1) Use real breed photos; (2) provide 15–20 tasks with more ≥5-step reasoning; (3) remove the credential leak; (4) verify card-vs-detail answer placement. Best functional depth of the contributor's set.
JeremyJC67
added a commit
to JeremyJC67/WebHarbor
that referenced
this pull request
Jul 2, 2026
Addresses review on PR aiming-lab#53: - Rebase onto current main; register healthline as index 16 -> port 40016 (append after merriam_webster in websyn_start.sh + control_server.py; Dockerfile EXPOSE -> 40000-40016). merriam_webster preserved. - websyn_start.sh site-count comments reconciled to 17. - .assets-revision pinned to HF PR aiming-lab#40 (clean tarball, no macOS AppleDouble junk, based on current main -> all 17 tarballs). Bump to merged SHA once HF PR aiming-lab#40 lands. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note