Skip to content

Add AKC mirror site#40

Open
Sun-sunshine06 wants to merge 1 commit into
aiming-lab:mainfrom
Sun-sunshine06:feat/akc-mirror-upstream
Open

Add AKC mirror site#40
Sun-sunshine06 wants to merge 1 commit into
aiming-lab:mainfrom
Sun-sunshine06:feat/akc-mirror-upstream

Conversation

@Sun-sunshine06

Copy link
Copy Markdown

Summary

  • Adds an American Kennel Club mirror under sites/akc with breed browsing, breed selector, compare, advice, events, login/profile, saved breeds, and event registration flows.
  • Registers akc as the next site on the upstream 15-site base, exposed on port 40015.
  • Adds Docker build-time seed generation for the code-generated SQLite seed DB.

Verification

  • sites/akc/venv/Scripts/python.exe -m py_compile sites/akc/app.py
  • python -m py_compile control_server.py
  • tasks.jsonl JSON parse check passed
  • Flask test client smoke: /, /breeds, /breeds/labrador-retriever, /breed-selector, /compare, /articles, /events, /search?q=agility, /login all returned 200
  • Login as alice.j@test.com and event registration flow returned 200

Note

  • This branch is rebased onto aiming-lab/WebHarbor main and does not include hqhq1025 fork-only site changes.

@Susan571 Susan571 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist (WebHarbor Review Guide)

Reviewer note: Source-level review (checked out pull/40/head). The mechanical Docker pipeline (build, curl 200, md5 reset) was not run in my environment — please pair with a Docker-capable mechanical pass.

Visual fidelity: ❌ FAIL

  • The most built-out of this contributor's set (app ~522 lines; breed_detail/compare/selector/events/articles; branded AKC header). But breed imagery is the /breed-art/<slug>.svg placeholder — real AKC pages are defined by distinctive breed photography, so this fails the real-images check.

Functional depth: ✅ PASS

  • Breed browse with group/size filters, breed detail, breed selector with real scoring logic (energy/grooming/apartment matching), compare, expert-advice articles, events with registration, login/register, save-breed, owner-profile update. Trait ratings (energy/grooming 1–5) mirror AKC's real trait scales.

Task quality: ⚠️ Request changes (10 tasks)

  • Good: AKC--1 (breed selector: apartment + moderate energy + low grooming → recommend), --2 (compare Golden Retriever vs Border Collie energy — decided on the compare page, not leaked), --5 (filter events to Training → CGC test city/state), --8 (register a dog for a webinar = real state change).
  • Only 10 tasks (need 15–20); AKC--3 leaks the password; confirm group/temperament answers require the detail page, not the card.

Verdict: Request changes

(1) Use real breed photos; (2) provide 15–20 tasks with more ≥5-step reasoning; (3) remove the credential leak; (4) verify card-vs-detail answer placement. Best functional depth of the contributor's set.

JeremyJC67 added a commit to JeremyJC67/WebHarbor that referenced this pull request Jul 2, 2026
Addresses review on PR aiming-lab#53:
- Rebase onto current main; register healthline as index 16 -> port 40016
  (append after merriam_webster in websyn_start.sh + control_server.py;
  Dockerfile EXPOSE -> 40000-40016). merriam_webster preserved.
- websyn_start.sh site-count comments reconciled to 17.
- .assets-revision pinned to HF PR aiming-lab#40 (clean tarball, no macOS AppleDouble
  junk, based on current main -> all 17 tarballs). Bump to merged SHA once
  HF PR aiming-lab#40 lands.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants