Support for device code auth#248
Open
anvilpete wants to merge 1 commit into
Open
Conversation
anvilpete
commented
Jun 26, 2026
| mode: "url", | ||
| // This should be the authenticate requestId, but this is not exposed by the ACP SDK. | ||
| // The elicitation still works, but won't be tied to the authenticate request. | ||
| requestId: null, |
Author
There was a problem hiding this comment.
I don't think we can fill in the requestId here without support to expose it from the ACP SDK.
I think this is fine for now, but could we consider adding requestId to the AgentHandlerContext?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds device code auth support for ChatGPT login when no browser is available. It is a re-implementation of zed-industries/codex-acp#291 for agentclientprotocol/codex-acp.
An
elicitation/completeisn't required, due to theAuthenticateResponsesent when authentication is complete (or an error if it failed).