feat: pvcRoles label for Kafka PVCs#255
Open
hvan wants to merge 4 commits into
Open
Conversation
hvan
changed the title
…nistic labels - Extract private processRolesValue() on BrokerConfig as a single source of truth for the role join logic used by both GetBrokerLabels (processRoles pod label) and GetPvcRolesLabelValue (pvcRoles PVC label) - Sort roles before joining so both labels are alphabetically ordered regardless of CR authoring order ([controller, broker] and [broker, controller] both produce broker_controller) - Add backfill log line in PVC reconcile path so operators can observe the one-time label backfill on existing PVCs after upgrade Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hvan
changed the title
hvan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new pvcRoles label on PVCs created by the Kafka reconciler to reflect the process role(s) of the broker that owns the storage. In KRaft mode, the label value mirrors the node's processRoles (e.g. broker, controller, or broker_controller). In ZooKeeper mode, all nodes are brokers so the label is always broker.