fix(storage): use plain response body in case of XML deserialization error - #1245
Open
dominique-pfister wants to merge 2 commits into
Open
fix(storage): use plain response body in case of XML deserialization error#1245dominique-pfister wants to merge 2 commits into
dominique-pfister wants to merge 2 commits into
Conversation
Comment on lines
+573
to
+576
| nock(`https://helix-code-bus.${CLOUDFLARE_ACCOUNT_ID}.r2.cloudflarestorage.com`) | ||
| .delete('/foo?x-id=DeleteObject') | ||
| .times(3) | ||
| .reply(expected.status, expected.message); |
Contributor
Author
There was a problem hiding this comment.
return a plain error message, no XML
tripodsan
approved these changes
Jul 27, 2026
|
This PR will trigger a patch release when merged. |
| this._r2 = new S3Client({ | ||
| ...baseOpts, | ||
| endpoint: `https://${r2AccountId}.r2.cloudflarestorage.com`, | ||
| region: 'us-east-1', // https://github.com/aws/aws-sdk-js-v3/issues/1845#issuecomment-754832210 |
Contributor
Author
There was a problem hiding this comment.
us-east-1 takes precedence over baseOpts.region
| r2SecretAccessKey: CLOUDFLARE_R2_SECRET_ACCESS_KEY, | ||
| bucketMap: parseBucketNames(), | ||
| disableExpectContinueHeader: true, | ||
| maxAttempts: 1, |
Contributor
Author
There was a problem hiding this comment.
fail once in tests, then abort
tripodsan
requested changes
Jul 27, 2026
tripodsan
left a comment
tripodsan
left a comment
Contributor
There was a problem hiding this comment.
I do not agree with the order of the base opts
| this._r2 = new S3Client({ | ||
| ...baseOpts, | ||
| endpoint: `https://${r2AccountId}.r2.cloudflarestorage.com`, | ||
| region: 'us-east-1', // https://github.com/aws/aws-sdk-js-v3/issues/1845#issuecomment-754832210 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.