fix(proxy): create IAM role for helix-deploy-proxy if necessary - #935
Merged
Conversation
Restricts the CloudWatch Logs permissions on the helix-deploy-proxy role to its own log group instead of granting access to all log groups in the account.
|
This PR will trigger a patch release when merged. |
| Code: { ZipFile: zipFile }, | ||
| })); | ||
| FunctionArn = res.FunctionArn; | ||
| functionArn = await this.createFunctionWithRetry(roleArn, zipFile); |
Contributor
Author
There was a problem hiding this comment.
this is not immediately obvious: creating a role takes some time before it can be used, which is why we retry creating the function with that new role
tripodsan
approved these changes
Jul 19, 2026
adobe-bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
## [14.1.1](v14.1.0...v14.1.1) (2026-07-20) ### Bug Fixes * **proxy:** create IAM role for `helix-deploy-proxy` if necessary ([#935](#935)) ([3c007fa](3c007fa))
|
🎉 This PR is included in version 14.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.