fix: log R2 errors on source GET 500s - #307
Merged
Merged
Conversation
getObject's catch block only logged when the S3/R2 error carried no httpStatusCode. Real backend failures (R2 returning a 500 InternalError) do carry one, so the most common case fell through silently, returning a bare 500 with nothing in Cloudflare Logs to diagnose it. Log whenever status >= 500, matching the convention already used in storage/version/put.js. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Keep the original 'Error getting object without httpStatusCode' message for network/timeout failures, alongside the new 'Error getting object' message for backend error responses — both now gated on status >= 500. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
adobe-bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
## [1.13.3](v1.13.2...v1.13.3) (2026-07-23) ### Bug Fixes * log R2 errors on source GET 500s ([#307](#307)) ([db8f824](db8f824))
Collaborator
|
🎉 This PR is included in version 1.13.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getObject's catch block only calledconsole.errorwhen the S3/R2 error had no$metadata.httpStatusCode. Real backend failures (R2 returning a 500InternalError) do carry one, so the common case fell through silently — Cloudflare Logs showed nothing to diagnose it.sourceGET 500s spread across 20+ unrelated orgs, self-resolved in ~10min, with zero log detail to confirm root cause.status >= 500, matching the existing convention instorage/version/put.js.Test plan
test/storage/object/get.test.jsreproducing an R2 500 withhttpStatusCodeset — confirmed it fails on pre-fix code and passes with the fixnpm run lintcleantest/storage/object/get.test.js+move.test.jssuite passing